Rename note to notification throughout the codebase wherever necessary
#1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
May 28, 2024
|
@ahoppen, let me know if there's anything else that needs to be fixed :) |
lokesh-tr
force-pushed
the
rename-note-to-notification-wherever-necessary
branch
from
75555a8 to
d3de458
Compare
lokesh-tr
force-pushed
the
rename-note-to-notification-wherever-necessary
branch
from
d3de458 to
1a45220
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all the occurences of
notein the code base tonotificationwherever it doesn't refer to diagnostics information.This change aims to maintain clarity across the codebase and sorts out any confusion / ambiguity with the terminology.
Rectified Terminology:
note: Diagnostics Informationnotification: Notificationrdar://116703667
Fixes #865